-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added target_os cfg feature to header translator #433
Open
simlay
wants to merge
24
commits into
madsmtm:master
Choose a base branch
from
simlay:add-unavailability-to-target_os
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+219
−56
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
fabf5ed
Added target_os cfg feature to header translator
simlay 7de510b
Removed irrelevant comment
simlay 615c4de
Remove empty new lines from generation
simlay 429ac57
Update ref to submodule
simlay 3db4f6c
Added library_unavailability to remove un-needed config attributes
simlay 57d3bd7
Removed cfg target for maccatalyst
simlay 39ce7d5
Made use of cfg target in library imports
simlay e04eaa8
cargo fmt
simlay cce841a
submodule bump
simlay 747216d
update submodule
simlay ae84ab9
Fix compiling for macos
simlay 5fb969e
Fix iOS and macOS compiling
simlay f9d3d4f
Fixed enum variant imports
simlay 492e0a8
cargo fmt
simlay 7edae2c
Fix clippy lints maybe
simlay 61d1aa7
Fix clippy lint
simlay 13a8a32
Updates from code review
simlay 4b34fd4
Remove any when theres only one os
simlay 677ae87
Move library_unavailability into context
simlay 0df1d04
cargo clippy
simlay fb2265a
Merge branch 'master' of github.com:madsmtm/objc2 into add-unavailabi…
simlay 9bd8ab3
cargo fmt
simlay dbe1782
Update submodule for new header-translator
simlay f1791dc
Fix superclass availability
simlay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Made use of cfg target in library imports
- Loading branch information
commit 39ce7d59c9884b69a4b7822c2449fab2bd9f46a2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[deprecated]
now also appears onimpl ClassType
, which is incorrect.So perhaps we should split out the
Unavailable
fromAvailability
(and maybe rename it toPlatformCfg
)? Since that part is always going to be acfg
-gate, which has interactions with higher-levelcfg
-gates (and must propagate to imports likegenerated/[Framework]/mod.rs
), whileintroduced
anddeprecated
will always only need to apply to the statement/method/field they're associated with.Maybe it would even make sense to add
PlatformCfg
as a field ofItemIdentifier
? Since these two are access so often together.