Future-proof struct encodings #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
bug
4 tasks
madsmtm
force-pushed
the
future-proof-struct-encodings
branch
from
05e6906 to
d49a190
Compare
madsmtm
added a commit
to rust-windowing/glutin
that referenced
this pull request
Apr 18, 2024
madsmtm/objc2#526 has been fixed
kchibisov
pushed a commit
to rust-windowing/glutin
that referenced
this pull request
Apr 18, 2024
- `icrate` has been deprecated in favour of separate crates per framework, in our case `objc2-foundation` and `objc2-app-kit`. - Moved `MainThreadMarker::run_on_main` to free-standing function `run_on_main`. - Changed how features work, this should result in less code that needs to be compiled. Links: madsmtm/objc2#526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust-windowing/glutin#1640 the encoding of the
CGLContextObjobject changed between versions of macOS. As such, this is something that we must be prepared to handle in our encoding comparison routines.