Fix Rust panics in exception::catch, and make it safe
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
force-pushed
the
exception-unwind
branch
from
22b2560 to
8c16687
Compare
madsmtm
force-pushed
the
exception-unwind
branch
from
8c16687 to
76567af
Compare
|
I tested x86 macOS, Rust panics are turned into aborts (probably because in the search phase, it tries to unwind through a frame that doesn't have CFI information). So that's fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of foreign exceptions unwinding into Rust is defined since rust-lang/rust#128321 (see also the yet unmerged reference PR: rust-lang/reference#1226).
My understanding of how the Objective-C runtime deals with exceptions leads me to believe that the reverse is also defined, i.e. that Rust exceptions unwinding into Objective-C is sound. The big hint is that Objective-C literally has a language primitive for catching foreign exceptions,
@catch(...).I am yet unsure about x86 macOS (old Objective-C runtime), I think they use longjumps and whatnot, will have to test that.