Use Clang's -fmodules
#678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
Clang has something called "modules", which are a mechanism to describe and combine a set of headers into a single cohesive unit: https://clang.llvm.org/docs/Modules.html This is what Swift uses when mapping frameworks, so it makes sense for us to do the same. Objective-C also recently gained the `@import` syntax to do the same. This should unblock our support for umbrella frameworks, makes it easier to use API notes in the future, and is generally more correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang has something called "modules", which are a mechanism to describe and combine a set of headers into a single cohesive unit. This is what Swift uses when mapping frameworks, so it makes sense for us to do the same. Objective-C also recently gained the
@importsyntax to do the same.I've been wanting to use this for a while, but I couldn't figure out the right set of flags to use to get Clang - that is, until today! The secret sauce was a combination of passing the
.modulemapas the root file, and using the-Xclang -emit-moduleflags.This should unblock #640, makes it easier to use API notes in the future, makes the separation between frameworks/modules cleaner (might even be able to do make the header translator multi-threaded in the future?), and is generally more correct.