-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Fully deprecate objc2::rc::{Id, WeakId}
#679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this should be the last remaining part required in order to close #617.
I think I'd also like to figure out #[method_id(...)]
, I've added mention of #457 to the issue description.
With this, 0.6 should be in a good position to be delivered, or are there still a lot of things to do? What I see in https://github.com/madsmtm/objc2/milestone/6 seems that it could be optional while the important changes that are already completed would be nice if published and back-porting things I would need in a fork would be cumbersome.
Ugh, I'm so bad at deciding when to release, in my defence things are complicated by us having a fairly large amount of dependents, and thus infrequent breaking versions are desirable for the ecosystem in general. But you are right, we are close, the target date I've set for the milestone (end of the year) should be accurate now, the remaining stuff that I really want to get in is:
- Proper enum prefix stripping, having to write
NSWindowSharingType::NSWindowSharingNone
is really ugly whenNSWindowSharingType::None
could do. - The cargo features stuff (removing
"all"
in favour of enabling things by default + std features shouldn't enable sub-features), since it's a breaking change. - The autogenerated thunks for functions, since it's also a breaking change, and it's needed for nicer Metal integration (allows
objc2-metal
to really shine overmetal-rs
).
(So if you want to explore some of those, then feel free to ;) )
As part of madsmtm#617. Signed-off-by: Paul Mabileau <[email protected]>
6bfc3a7
to
cb335af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
OK, changed the description accordingly.
Most definitely understandable. Another way to see things though is that breaking a lot at the same time makes transitioning harder, while more frequent but more focused breakage is somewhat more manageable. Tough choices overall.
That is more than acceptable, especially considering vacations and stuff. It should also align nicely with a development I will take on again.
I just might, but maybe only the first two 😉
You're welcome! |
objc2::rc::Id
objc2::rc::{Id, WeakId}
As part of #617.
With this, 0.6 should be in a good position to be delivered, or are there still a lot of things to do? What I see in https://github.com/madsmtm/objc2/milestone/6 seems that it could be optional while the important changes that are already completed would be nice if published and back-porting things I would need in a fork would be cumbersome.