Ability - case insensitive check of admin_role #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouranos
force-pushed
the
feature/ability-admin-case
branch
from
963cfa3
to
748027c
Compare
x4d3
reviewed
Jun 13, 2017
| @@ -141,7 +141,7 @@ def impac_abilities(user) | |||
|
|
|||
| # Abilities for admin user | |||
| def admin_abilities(user) | |||
| if user.admin_role == 'admin' | |||
| if user.admin_role.try(:downcase) == 'admin' | |||
There was a problem hiding this comment.
I would prefer 'admin'.casecmp(user.admin_role)
There was a problem hiding this comment.
Ah didn't know this one.
Interestingly, it seems better to use downcase + == in ruby 2.4:
- Remove (disable) Perfomace/Casecmp (at least for Ruby 2.4) rubocop/rubocop#4277
- Remove
String#casecmppart fastruby/fast-ruby#123
In anycase, the role is not unicode so it should be safe to use 'admin'.casecmp(user.admin_role).zero?
There was a problem hiding this comment.
Updated, let me know if good and I'll squash the commits once the specs are green
x4d3
approved these changes
Jun 13, 2017
ouranos
force-pushed
the
feature/ability-admin-case
branch
from
4aace74
to
8f2638f
Compare
aluqueGH
pushed a commit
to aluqueGH/mno-enterprise
that referenced
this pull request
Jul 10, 2018
Remove time from subscriptions start and end dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.