Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy Info endpoint URL fixed #41

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

gavinharris-dev
Copy link
Contributor

Summary

The URL for Policy Info seems to have been changed with some recent updates to the Maestro API, this change is to bring the SDK into line for this API endpoint

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

Additional Information

Updated the SDK to call the end point as published here: https://docs.gomaestro.org/Indexer-API/Asset%20Policy/policy-assets

The URL for Policy Info seems to have been changed with some recent updates to the Maestro API, this change is to bring the SDK into line for this API endpoint
@gavinharris-dev gavinharris-dev requested a review from a team as a code owner March 14, 2024 01:48
@gavinharris-dev
Copy link
Contributor Author

There are probably more locations where the SDK is out of step with the API. This PR is to fix the one location where I have hit into an issue.

@Vardominator Vardominator merged commit 686ba60 into maestro-org:main Mar 17, 2024
1 check passed
@gavinharris-dev gavinharris-dev deleted the patch-1 branch March 18, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants