Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegation balance #42

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Conversation

sanjay-del
Copy link
Contributor

Thank you for contributing to Maestro! We appreciate your effort and dedication to improving this project. To ensure that your contribution is in line with the project's guidelines and can be reviewed efficiently, please fill out the template below.

Remember to follow our Contributing Guide before submitting your pull request.

Summary

Please provide a brief, concise summary of the changes in your pull request. Explain the problem you are trying to solve and the solution you have implemented.

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

Testing

Please describe the tests you have added or modified, and provide any additional context or instructions needed to run the tests.

  • Test A
  • Test B

Additional Information

This PR closes the issue #35 (Stake account delegation history) and completes one task from issue #34 (Balance by payment credential endpoint)

@sanjay-del sanjay-del requested a review from a team as a code owner March 26, 2024 02:15
@sanjay-del sanjay-del closed this Mar 31, 2024
@sanjay-del sanjay-del reopened this Mar 31, 2024
@sanjay-del
Copy link
Contributor Author

@Vardominator

@Vardominator
Copy link
Contributor

@sanjay-del Looks good. Can you please bump the version in package.json to 1.5.4 before we merge?

@sanjay-del
Copy link
Contributor Author

@Vardominator updated package json version

Copy link
Contributor

@Vardominator Vardominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!!

@Vardominator Vardominator merged commit d95c4c2 into maestro-org:main Mar 31, 2024
1 check passed
@Vardominator
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants