Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Search Param Names): "withCbor" and "resovleDatums" to match API spec #43

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

gavinharris-dev
Copy link
Contributor

Thank you for contributing to Maestro! We appreciate your effort and dedication to improving this project. To ensure that your contribution is in line with the project's guidelines and can be reviewed efficiently, please fill out the template below.

Remember to follow our Contributing Guide before submitting your pull request.

Summary

The Search Attributes withCbor and resolveDatums do not match the required format as shown in the API specification (https://docs.gomaestro.org/Indexer-API/Addresses/utxos-by-address). This change is to bring the API Types in line with the API specification.

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

@gavinharris-dev gavinharris-dev requested a review from a team as a code owner April 3, 2024 00:03
Copy link
Contributor

@Vardominator Vardominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavinharris-dev Can you please update version in package.json to 1.5.5?

@Vardominator Vardominator merged commit c37d36e into maestro-org:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants