Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass error as argument to stream.destroy #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass error as argument to stream.destroy #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ var destroyer = function (stream, reading, writing, callback) {
if (isFS(stream)) return stream.close(noop) // use close for fs streams to avoid fd leaks
if (isRequest(stream)) return stream.abort() // request.destroy just do .end - .abort is what we want

if (isFn(stream.destroy)) return stream.destroy()
if (isFn(stream.destroy)) return stream.destroy(err)

callback(err || new Error('stream was destroyed'))
}
Expand All @@ -69,7 +69,7 @@ var pump = function () {
var writing = i > 0
return destroyer(stream, reading, writing, function (err) {
if (!error) error = err
if (err) destroys.forEach(call)
if (err) destroys.forEach(fn => fn(err))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No arrow functions

if (reading) return
destroys.forEach(call)
callback(error)
Expand Down