Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check if ancient when not in browser #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markoorn
Copy link

@markoorn markoorn commented Dec 5, 2022

I've moved the ancient check to be after the browser check to bypass the browser error:

index.js:6 Uncaught ReferenceError: process is not defined
at ../../node_modules/pump/index.js (index.js:6:29)
at __require2 (chunk-KQHTJEE7.js:18:50)
at utils.ts:25:2

@markoorn markoorn mentioned this pull request Dec 5, 2022
Copy link

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think this works it seems like an explicit check for process would be more clear in the code. Either way, adding an approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants