fix: address latest norminette v3.3.55 update incompatibility issue #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest norminette v3.3.55 doesn't allow students to choose between the K&R or Allman indentation style; instead, it enforces the use of the latter. The K&R indentation style is used in the original Unix kernel, while the Allman style is used in BSD Unix.
Deciding whether to pin the tools used on CD/CI or to keep them updated is a complex question. We must consider factors such as stability versus being up-to-date, security, long-term maintenance, and compatibility. Therefore, I opted for a balanced approach, pinning the Norminette version to v3.3.51, which was the latest version at the time this project was developed and its only major tool.
Since the project is finished, it doesn't require long-term maintenance, nor will it have major security issues since the tool used is only a code formatter. Therefore, I addressed the issue of compatibility as our whole project is structured to adhere to norminette v3.3.51.
However, while I was at it, I decided to make some minor changes to the code to conform to the new norm and only left the critical ones. The norminette v3.3.55 is stricter than the old one regarding preprocessor definitions. The log below references the file
include/hash_table.h
:To sum up, this PR ensures that our CI/CD doesn't break due to external changes if we further tinker with this hard and amusing project.