review bug ticket: add order status in order type

mageplaza · Aug 31, 2020 · 914046a · 914046a
1 parent 15e8fef
commit 914046a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/Helper/Data.php b/Helper/Data.php
@@ -169,7 +169,7 @@ public function send($item, $hookType)
             if ($hook->getHookType() === HookType::ORDER) {
                 $statusItem = $item->getStatus();
                 $orderStatus = explode(',', $hook->getOrderStatus());
-                if (!in_array($statusItem, $orderStatus)) {
+                if (!in_array($statusItem, $orderStatus, true)) {
                     continue;
                 }
             }

diff --git a/Observer/AfterOrder.php b/Observer/AfterOrder.php
@@ -21,8 +21,6 @@
 
 namespace Mageplaza\Webhook\Observer;
 
-use Exception;
-use Magento\Framework\Event\Observer;
 use Mageplaza\Webhook\Model\Config\Source\HookType;
 
 /**
@@ -35,14 +33,4 @@ class AfterOrder extends AfterSave
      * @var string
      */
     protected $hookType = HookType::ORDER;
-
-    /**
-     * @param Observer $observer
-     *
-     * @throws Exception
-     */
-    public function execute(Observer $observer)
-    {
-        parent::execute($observer); // TODO: Change the autogenerated stub
-    }
 }