Add missing comma for function call with arrow function as argument #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Apr 1, 2024
Ocramius
added
enhancement
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions before 8.15.0 the
SlevomatCodingStandard.Functions.RequireTrailingCommaInCallsniff had a false-negative for arrow functions. This has been fixed in version 8.15.0 as noted in the release notes. See slevomat/coding-standard@8d0f603 for the specific commit which resolves this issue.The change in this pull request should allow the test suite to pass for #535 where the version of the Slevomat coding standard has been increased from 8.14.1 to 8.15.0.