Remove now-unnecessary PHP <8.2 code
#554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
changed the title
<8.2 code
|
nice to see the PHPStan feature I have built into 2.x with phpstan/phpstan-src@6924e46 already finds dead code. love it :-) |
|
@staabm you did so many impactful improvements on phpstan over the last 2 years: bravo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a look at the test failures / changes in #552. It turns out that the code here can be safely removed, as we no longer support PHP versions below 8.2.0 - see #460 for that change.
This pull request fixes one of the two test failures in #552.