Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format BSD license to be recognizable by GitHub license detector #281

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

elliotwutingfeng
Copy link
Contributor

Currently the repository's license is not recognized correctly by GitHub's license detector.

This edit makes it recognizable so that this repository will show up in GitHub search results as "BSD 3-Clause" licensed and not "Other".

As this is a minor edit, feel free to close this and use (https://choosealicense.com/licenses/bsd-3-clause)'s format.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e0c552) 98.05% compared to head (7186945) 98.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files          27       27           
  Lines        4362     4362           
  Branches      765      765           
=======================================
  Hits         4277     4277           
  Misses         54       54           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahmoud mahmoud merged commit 3cd57b6 into mahmoud:master Jan 12, 2024
11 checks passed
@mahmoud
Copy link
Owner

mahmoud commented Jan 12, 2024

GitHub, so finnicky :P Thanks for this!

@elliotwutingfeng elliotwutingfeng deleted the patch-1 branch January 13, 2024 00:12
@elliotwutingfeng
Copy link
Contributor Author

Ugh, it didn't work :(

@mahmoud
Copy link
Owner

mahmoud commented Jan 13, 2024

Haha, yeah I just checked, thought it might be cached/on a batch job, but it's been 24 hours. Feel free to follow up if you've got more theories, otherwise I'll add it to my TODO :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants