Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide node-manager command #22

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

jacderida
Copy link
Contributor

  • 58aa96f refactor: download and extract using sn-releases crate

    The code for downloading and extracting release binaries from Github and S3 was being repeated in
    several different places, so we decided to put some common code for it in a crate.

    We are now updating safeup to use it, which removes both the github and s3 modules, and makes
    the install_bin tests simpler.

    From the user's point of view, functionally everything should be the same.

    I also added a quick Vagrantfile here that can be used for testing safeup. This is useful if you
    don't want your local machine littered with binaries that were only used for testing.

  • 3d2b33a feat: provide node-manager command

    BREAKING CHANGE: the new settings file will have additional entries for keeping track of the
    safenode-manager installation. Previously serialised settings files will be incompatible with this
    change. Users will need to clear their previous settings file when they upgrade.

    This will install the node manager alongside the other binaries. After the sn-releases crate was
    extended for the new release type, adding the new command was quite straight forward, since it's
    just the installation of another binary.

    At some point later we may need to extend this installation to also distribute the RPC client, which
    may be required for the node manager if we're going to use it in service shutdown commands. For now
    though, it's just distributing the safenode-manager binary.

The code for downloading and extracting release binaries from Github and S3 was being repeated in
several different places, so we decided to put some common code for it in a crate.

We are now updating `safeup` to use it, which removes both the `github` and `s3` modules, and makes
the `install_bin` tests simpler.

From the user's point of view, functionally everything should be the same.

I also added a quick Vagrantfile here that can be used for testing safeup. This is useful if you
don't want your local machine littered with binaries that were only used for testing.
BREAKING CHANGE: the new settings file will have additional entries for keeping track of the
safenode-manager installation. Previously serialised settings files will be incompatible with this
change. Users will need to clear their previous settings file when they upgrade.

This will install the node manager alongside the other binaries. After the `sn-releases` crate was
extended for the new release type, adding the new command was quite straight forward, since it's
just the installation of another binary.

At some point later we may need to extend this installation to also distribute the RPC client, which
may be required for the node manager if we're going to use it in service shutdown commands. For now
though, it's just distributing the `safenode-manager` binary.
@jacderida jacderida merged commit dfd8bcb into maidsafe:main Dec 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants