Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
58aa96f refactor: download and extract using
sn-releases
crateThe code for downloading and extracting release binaries from Github and S3 was being repeated in
several different places, so we decided to put some common code for it in a crate.
We are now updating
safeup
to use it, which removes both thegithub
ands3
modules, and makesthe
install_bin
tests simpler.From the user's point of view, functionally everything should be the same.
I also added a quick Vagrantfile here that can be used for testing safeup. This is useful if you
don't want your local machine littered with binaries that were only used for testing.
3d2b33a feat: provide
node-manager
commandBREAKING CHANGE: the new settings file will have additional entries for keeping track of the
safenode-manager installation. Previously serialised settings files will be incompatible with this
change. Users will need to clear their previous settings file when they upgrade.
This will install the node manager alongside the other binaries. After the
sn-releases
crate wasextended for the new release type, adding the new command was quite straight forward, since it's
just the installation of another binary.
At some point later we may need to extend this installation to also distribute the RPC client, which
may be required for the node manager if we're going to use it in service shutdown commands. For now
though, it's just distributing the
safenode-manager
binary.