feature: use Element.computedStyleMap()
#2143
Open
+167
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryThePenguin
commented
Oct 9, 2024
| @@ -41,6 +41,7 @@ | |||
| "devDependencies": { | |||
| "@arethetypeswrong/cli": "0.15.4", | |||
| "@types/qunit": "2.19.10", | |||
| "@typescript/lib-dom": "npm:@types/[email protected]", | |||
There was a problem hiding this comment.
https://www.npmjs.com/package/@types/web for the new Web APIs
BarryThePenguin
commented
Oct 9, 2024
Comment on lines
-32
to
-34
| type CSSStyleDeclarationProperty = keyof CSSStyleDeclaration; | ||
|
|
||
| type ActualCSSStyleDeclaration = Partial<Record<CSSStyleDeclarationProperty, unknown>>; |
There was a problem hiding this comment.
I don't think these types provide much value as they are only used internally, with a type assertion..
I think these types are better represented as a plain record, eg; Record<string, string>
BarryThePenguin
commented
Oct 9, 2024
Comment on lines
+832
to
+833
| let computedStyle = getComputedStyle(element, selector); | ||
| let expectedProperties = Object.keys(expected); |
There was a problem hiding this comment.
🗑️ the type assertion
BarryThePenguin
commented
Oct 9, 2024
Comment on lines
-844
to
+841
| property => | ||
| (computedStyle.getPropertyValue(property.toString()) || computedStyle[property]) === | ||
| expected[property] | ||
| property => computedStyle[property] === expected[property] |
There was a problem hiding this comment.
camelCase and kebab-case properties are handled by getComputedStyle()
BarryThePenguin
commented
Oct 9, 2024
Comment on lines
+4
to
+6
| if (!selector && 'computedStyleMap' in element) { | ||
| computedStyleMap = element.computedStyleMap(); | ||
| } |
There was a problem hiding this comment.
Element.computedStyleMap() doesn't work with with pseudo-elements, so it should fallback to window.getComputedStyle() in those cases
BarryThePenguin
commented
Oct 9, 2024
Comment on lines
+20
to
+24
| return ( | ||
| value || | ||
| computedStyle.getPropertyValue(property.toString()) || | ||
| Reflect.get(computedStyle, property) | ||
| ); |
There was a problem hiding this comment.
Maintains the previous logic of
computedStyle.getPropertyValue(property.toString()) || computedStyle[property]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
Element.computedStyleMap()to evaluate element styles when it is available. Firefox is the only browser that hasn't implemented CSS Typed OM https://ishoudinireadyyet.com/I was running into issues where
hasStyle()was returning outdated values. Specifically when an element had a cssheight: 100pxand JavaScript that updated it with an inline style ofheight: 85%, it would return the oldheight: 100pxvalue