Add bin folder to python targets, and adapt the regular python layout (save for the zip). #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
python-bin
branch
4 times, most recently
from
9b5e79d to
956dd1a
Compare
… (save for the zip). Use the zip upload archive method in the github runner for macOS, too, to preserve permissions.
maiself
added
documentation
Ivorforce
commented
Oct 29, 2024
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: godot-python-${{ matrix.platform }}-${{ matrix.arch }} | ||
| path: bin/**/* | ||
| path: godot-python-${{ matrix.platform }}-${{ matrix.arch }}.zip |
There was a problem hiding this comment.
I was hoping providing a single path would make it upload the file as-is, but it's still zipping the zip. Need to find a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19. We should probably document this (and / or make it simpler), but this is a good start.
This allows godot-python users to use python (and pip) out of the box:
The python binary points to
@executable_path/../lib/libpython3.12.dylibso it's already configured correctly with this new layout (i.e. python lib moved topython/lib).The bin folder is
.gdignore'd.