Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHG metrics integration #5

Merged
merged 16 commits into from
May 17, 2024
Merged

Add PHG metrics integration #5

merged 16 commits into from
May 17, 2024

Conversation

btmonier
Copy link
Member

This PR adds the following:

  • Added new class PHGMetrics
    • Primary container for PHGv2 metrics data
  • Added accessor methods for PHGMetrics objects:
    • metricsIds()
    • metricsTable()
    • metricsMetaData()
  • Prior methods are also updatable
  • Added visualization methods:
    • plotDot() - collinearity plotter for alignment data
  • Added documentation article (metrics.Rmd)

@btmonier btmonier added the enhancement New feature or request label May 14, 2024
@btmonier btmonier requested review from tcasstevens, lynnjo and zrm22 May 14, 2024 14:31
@btmonier btmonier self-assigned this May 14, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

)

})

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it really matters, but is there a reason for all these extra new lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I usually add a big buffer of new lines when typing/editing so I can constantly have text lines near the top-middle part of my screen, and I forgot to remove them.

@btmonier btmonier merged commit e2cbff7 into main May 17, 2024
4 checks passed
@btmonier btmonier deleted the phg-metrics branch May 17, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants