-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2678]feat: added functionality to add labels directly from dropdown #6208
base: preview
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request introduces changes to the label management components across multiple files in the web application. The modifications primarily focus on simplifying label creation and handling, removing explicit user permission checks, and adding a more streamlined mechanism for creating labels directly from various issue-related components. The changes enhance the label selection and creation process by introducing a new Changes
Sequence DiagramsequenceDiagram
participant User
participant LabelSelect
participant LabelOperations
participant Backend
User->>LabelSelect: Enter new label name
LabelSelect->>LabelOperations: onAddLabel()
LabelOperations->>Backend: Create Label
Backend-->>LabelOperations: Label Created
LabelOperations-->>LabelSelect: Return New Label
LabelSelect->>User: Update UI with New Label
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
web/core/components/issues/issue-detail/label/root.tsx
(1 hunks)web/core/components/issues/issue-detail/label/select/label-select.tsx
(3 hunks)web/core/components/issues/issue-detail/label/select/root.tsx
(1 hunks)web/core/components/issues/issue-layouts/properties/labels.tsx
(7 hunks)
🔇 Additional comments (2)
web/core/components/issues/issue-detail/label/select/root.tsx (1)
29-29
: LGTM!
The addition of the onAddLabel
prop correctly passes the createLabel
function to the IssueLabelSelect
component, enhancing label creation functionality.
web/core/components/issues/issue-detail/label/root.tsx (1)
10-13
: Simplification by removing permission checks is acceptable
The removal of useUserPermissions
import and related permission checks simplifies the IssueLabel
component. Assuming that permission checks are enforced elsewhere, this change is appropriate.
const handleAddLabel = async (labelName: string) => { | ||
setSubmitting(true); | ||
const label = await onAddLabel(workspaceSlug, projectId, { name: labelName, color: getRandomLabelColor() }); | ||
onSelect([...values, label.id]); | ||
setQuery(""); | ||
setSubmitting(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling in handleAddLabel
to prevent unhandled exceptions
The handleAddLabel
function does not handle potential exceptions from onAddLabel
. If an error occurs during label creation, setSubmitting(false)
may not be called, leaving the component in a loading state, and the user won't receive feedback about the failure.
Apply this diff to add error handling:
const handleAddLabel = async (labelName: string) => {
+ try {
setSubmitting(true);
const label = await onAddLabel(workspaceSlug, projectId, { name: labelName, color: getRandomLabelColor() });
onSelect([...values, label.id]);
setQuery("");
+ } catch (error) {
+ // Handle error, possibly show error message to user
+ console.error(error);
+ } finally {
setSubmitting(false);
+ }
};
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
const handleAddLabel = async (labelName: string) => { | |
setSubmitting(true); | |
const label = await onAddLabel(workspaceSlug, projectId, { name: labelName, color: getRandomLabelColor() }); | |
onSelect([...values, label.id]); | |
setQuery(""); | |
setSubmitting(false); | |
const handleAddLabel = async (labelName: string) => { | |
try { | |
setSubmitting(true); | |
const label = await onAddLabel(workspaceSlug, projectId, { name: labelName, color: getRandomLabelColor() }); | |
onSelect([...values, label.id]); | |
setQuery(""); | |
} catch (error) { | |
// Handle error, possibly show error message to user | |
console.error(error); | |
} finally { | |
setSubmitting(false); | |
} | |
}; |
const handleAddLabel = async (labelName: string) => { | ||
if (!projectId) return; | ||
setSubmitting(true); | ||
const label = await createLabel(workspaceSlug, projectId, { name: labelName, color: getRandomLabelColor() }); | ||
onChange([...value, label.id]); | ||
setQuery(""); | ||
setSubmitting(false); | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling in handleAddLabel
to prevent unhandled exceptions
The handleAddLabel
function does not handle potential exceptions from createLabel
. If an error occurs during label creation, setSubmitting(false)
may not be called, leaving the component in a loading state, and the user won't receive feedback about the failure.
Apply this diff to add error handling:
const handleAddLabel = async (labelName: string) => {
if (!projectId) return;
+ try {
setSubmitting(true);
const label = await createLabel(workspaceSlug, projectId, { name: labelName, color: getRandomLabelColor() });
onChange([...value, label.id]);
setQuery("");
+ } catch (error) {
+ // Handle error, possibly show error message to user
+ console.error(error);
+ } finally {
setSubmitting(false);
+ }
};
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
const handleAddLabel = async (labelName: string) => { | |
if (!projectId) return; | |
setSubmitting(true); | |
const label = await createLabel(workspaceSlug, projectId, { name: labelName, color: getRandomLabelColor() }); | |
onChange([...value, label.id]); | |
setQuery(""); | |
setSubmitting(false); | |
}; | |
const handleAddLabel = async (labelName: string) => { | |
if (!projectId) return; | |
try { | |
setSubmitting(true); | |
const label = await createLabel(workspaceSlug, projectId, { name: labelName, color: getRandomLabelColor() }); | |
onChange([...value, label.id]); | |
setQuery(""); | |
} catch (error) { | |
// Handle error, possibly show error message to user | |
console.error(error); | |
} finally { | |
setSubmitting(false); | |
} | |
}; |
Description
Added functionality to add labels directly from drop-down if the label does not exist.
Type of Change
References
WEB-2678
Summary by CodeRabbit
New Features
Bug Fixes
Documentation