Allocator Vault Support #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexonaut
changed the title
hexonaut
changed the title
hexonaut
changed the title
Closed
|
I'm going to add some more tests, but this is getting close to being finished for review. |
|
Blocked by: #111 |
… as its less confusing
hexonaut
force-pushed
the
add-alm-controller
branch
from
6a7112c to
17d0044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
Integration Tests:
Some changes to the general interface:
IPoolhasliquidityAvailable()to return the total amount of liquidity that is immediately available in the pool.IPoolhasidleLiquidity()to determine how muchdaishould be discounted from fee calculations. This is not used now, but will be required later when fees are fully automated.IPlangetTargetAssets()takes in theilknow to allow a single contract for multiple ilks.IFeesadded to allow custom accounting when fees are returned instead of assuming everything goes to thevow. For now everything is set to just send everything to the vow.