Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aave pool adapter for usds #124

Merged
merged 16 commits into from
Aug 28, 2024
Merged

Add aave pool adapter for usds #124

merged 16 commits into from
Aug 28, 2024

Conversation

hexonaut
Copy link
Contributor

@hexonaut hexonaut commented Jul 31, 2024 •
edited
Loading

DuplicatedD3MAaveV3NoSupplyCapTypePool, but will swap DAI for USDS before depositing and after withdrawing. Recommend diffing the files to see what's changed.

Some Notes:

  • Disabled some Aave V2 tests because we aren't using them anymore, and they are failing.
  • Had to bump the solc version due to NST requirements.
  • I would diff the unit tests against the DAI version. I removed a few failing tests, but the unit tests provide limited coverage anyways. I think it's more important to review the integration tests.

@hexonaut hexonaut self-assigned this Jul 31, 2024
sunbreak1211
sunbreak1211 reviewed Aug 16, 2024
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
oldchili
oldchili previously approved these changes Aug 27, 2024
View reviewed changes
Copy link

@oldchili oldchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunbreak1211
sunbreak1211 previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@sunbreak1211 sunbreak1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new pool looks good and in general the PR looks good as well. Haven't gone through the integrations test very deep but the diff with Spark one look good.

@hexonaut hexonaut dismissed stale reviews from sunbreak1211 and oldchili via 1e9a37e August 27, 2024 16:06
@hexonaut hexonaut changed the title Add aave pool adapter for nst Add aave pool adapter for usds Aug 27, 2024
telome
telome reviewed Aug 27, 2024
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@sunbreak1211 sunbreak1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming looks good

oldchili
oldchili approved these changes Aug 28, 2024
View reviewed changes
Copy link

@oldchili oldchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming looks good

@hexonaut hexonaut merged commit 758b26c into master Aug 28, 2024
8 checks passed
@hexonaut hexonaut deleted the add-nst-aave-pool-adapter branch August 28, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telome telome telome left review comments

@oldchili oldchili oldchili approved these changes

@sunbreak1211 sunbreak1211 sunbreak1211 approved these changes

@lucas-manuel lucas-manuel Awaiting requested review from lucas-manuel

Assignees

@hexonaut hexonaut

Labels
Priority: High Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hexonaut @sunbreak1211 @telome @oldchili