Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: make DssVestSuckable.join a constructor parameter #65

Merged
merged 14 commits into from
Nov 5, 2024

Conversation

amusingaxl
Copy link
Contributor

No description provided.

@DaiFoundation-DevOps
Copy link

DaiFoundation-DevOps commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

@amusingaxl amusingaxl marked this pull request as ready for review October 14, 2024 20:33
@amusingaxl amusingaxl changed the title Refactor: make DssVestSuckable.join a constructor parameter Refactor: make DssVestSuckable.join a constructor parameter Oct 14, 2024
src/DssVest.t.sol Outdated Show resolved Hide resolved
certora/mocks/Vat.sol Outdated Show resolved Hide resolved
Copy link

@sunbreak1211 sunbreak1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

@0xp3th1um 0xp3th1um left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@telome telome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test changes look good. Didn't dive as deep on the Certora changes.

src/DssVest.sol Show resolved Hide resolved
src/DssVest.t.sol Outdated Show resolved Hide resolved
src/DssVest.t.sol Outdated Show resolved Hide resolved
@amusingaxl amusingaxl requested a review from oddaf October 30, 2024 13:34
@amusingaxl amusingaxl merged commit 41728f0 into master Nov 5, 2024
14 checks passed
@amusingaxl amusingaxl deleted the refactor/suckable branch November 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants