Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move html generation to onPagedRendered. #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jetrit
Copy link

@jetrit jetrit commented Dec 16, 2023

Markdown-extra has a problem with html snippets. so I would suggest moving the html injection to after markdown extra has processed the page.

@maloja
Copy link
Owner

maloja commented Dec 17, 2023

pico-fotofolder was originally developed for PicoCMS 2.14 for which there has been no update for years. At the moment there is also no stable version of PicoCMS for supported php environments (php >8.1), so unfortunately i have no possibility to test any pull-requests. In which environment do you use fotofolder?

@jetrit
Copy link
Author

jetrit commented Dec 17, 2023

I have it running on 3 machines:
aws php 7.3.15 jetrit.dk
chromebook php 7.4.33
ubuntu 22.04 php 8.1.2 with a minor fix of create_folder line 104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants