Merge pull request #229 from mamantoha/fix-resource-concat_urls

fix Crest::Resource#concat_urls

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## [...]
 
+- Fix Crest::Resource#concat_urls [#229](https://github.com/mamantoha/crest/pull/229)
+
 ## [1.4.0][] (2024-08-26)
 
 - Fix typo in README.md by @kojix2 in [#223](https://github.com/mamantoha/crest/pull/223)

src/crest.cr

@@ -8,7 +8,6 @@ require "./ext/io"
 require "./ext/int"
 require "./ext/float"
 require "./ext/http/cookie"
-require "./ext/uri"
 
 # This module's static methods are the entry point for using the Crest client.
 #

src/crest/resource.cr

@@ -232,8 +232,11 @@ module Crest
       other
     end
 
-    private def concat_urls(url : String, suburl : String) : String
-      URI.join(url, URI.parse(suburl)).to_s
+    private def concat_urls(base_url : String, path : String) : String
+      base_url = base_url.ends_with?('/') ? base_url[...-1] : base_url
+      path = path.starts_with?('/') ? path[1..] : path
+
+      [base_url, path].join('/')
     end
   end
 end