Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue #74 - implement "2x" images on retina devices #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolves issue #74 - implement "2x" images on retina devices #79

wants to merge 1 commit into from

Conversation

leptos-null
Copy link

@leptos-null leptos-null commented Oct 1, 2018

To appropriately implement "retina" images, the device screen scale is checked. #74 mentions 1084 being the first supported comic. If both these conditions are met, the string representing the URL is modified. Another option for the string manipulation is

        NSString *patchingImageString = [self.imageURLString stringByDeletingPathExtension];
        patchingImageString = [patchingImageString stringByAppendingString:@"_2x"]
        self.imageURLString = [patchingImageString stringByAppendingPathExtension:@"png"];

The above approach is more clear, however I felt that the performance trade-offs were not worth using it.

@Zarel
Copy link

Zarel commented Dec 27, 2019

Beginning at 1084, most comics are Retina, but a few before that are also Retina, such as 1053 and 1061.

@jsejcksn
Copy link

Adding to the dataset: Today I tested all comics from 1084 to 2266 for associated _2x.png files. I logged the response.ok values for each request, and all returned true except for these comic IDs, which returned false:

1097
1103
1110
1116
1127
1182
1190
1193
1229
1253
1264
1331
1335
1349
1350
1416
1446
1452
1461
1491
1506
1525
1551
1608
1663
1667
1735
1739
1744
1778
2202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants