Add tests for all similar cases of ThrowIfFail

managedcode · Sep 12, 2024 · 2d0fe2e · 2d0fe2e
1 parent 4edeba2
commit 2d0fe2e
Show file tree

Hide file tree

Showing 8 changed files with 52 additions and 27 deletions.
diff --git a/ManagedCode.Communication.Extensions/Properties/launchSettings.json b/ManagedCode.Communication.Extensions/Properties/launchSettings.json
diff --git a/ManagedCode.Communication.Tests/Properties/launchSettings.json b/ManagedCode.Communication.Tests/Properties/launchSettings.json
diff --git a/ManagedCode.Communication.Tests/Results/ResultFailTests.cs b/ManagedCode.Communication.Tests/Results/ResultFailTests.cs
@@ -15,6 +15,7 @@ public void Fail()
         fail.IsSuccess.Should().BeFalse();
         fail.IsFailed.Should().BeTrue();
         Assert.Throws<Exception>(() => fail.ThrowIfFail());
+        Assert.Throws<Exception>(() => fail.ThrowIfFailWithStackPreserved());
         Assert.True(fail == false);
         Assert.False(fail);
     }
@@ -74,6 +75,7 @@ public void FailThrow()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(Exception), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(Exception), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -87,6 +89,7 @@ public void FailExceptionThrow()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(ArithmeticException), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(ArithmeticException), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -100,6 +103,7 @@ public void FailFrom()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -114,6 +118,7 @@ public void FailT()
         fail.IsSuccess.Should().BeFalse();
         fail.IsFailed.Should().BeTrue();
         Assert.Throws<Exception>(() => fail.ThrowIfFail());
+        Assert.Throws<Exception>(() => fail.ThrowIfFailWithStackPreserved());
         Assert.True(fail == false);
         Assert.False(fail);
     }
@@ -176,6 +181,7 @@ public void FailTThrow()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(Exception), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(Exception), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -189,6 +195,7 @@ public void FailTExceptionThrow()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(ArithmeticException), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(ArithmeticException), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -206,6 +213,7 @@ public void SucceedTFrom()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -223,6 +231,7 @@ public async Task SucceedFromTask()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -297,6 +306,7 @@ public void FailGenericThrow()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(Exception), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(Exception), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -310,6 +320,7 @@ public void FailGenericExceptionThrow()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(ArithmeticException), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(ArithmeticException), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -327,6 +338,7 @@ public void SucceedGenericFrom()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -344,6 +356,7 @@ public async Task SucceedFromGenericTask()
         ok.IsFailed.Should().BeTrue();
 
         Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFail());
+        Assert.Throws(typeof(ArgumentException), () => ok.ThrowIfFailWithStackPreserved());
 
         Assert.True(ok == false);
         Assert.False(ok);
@@ -368,6 +381,25 @@ public async Task SeveralErrors()
         }
     }
 
+    [Fact]
+    public async Task SeveralErrorsWithStackPreserved()
+    {
+        var result = Result.Fail();
+        result.AddError(Error.Create("oops1"));
+        result.AddError(Error.Create("oops2"));
+        result.AddError(Error.Create("oops3"));
+
+        try
+        {
+            result.ThrowIfFailWithStackPreserved();
+        }
+        catch (AggregateException e)
+        {
+            e.Message.Should().Be("One or more errors occurred. (oops1) (oops2) (oops3)");
+            e.InnerExceptions.Count.Should().Be(3);
+        }
+    }
+
     [Fact]
     public void ExceptionParse()
     {

diff --git a/ManagedCode.Communication.Tests/Results/ResultSucceedTests.cs b/ManagedCode.Communication.Tests/Results/ResultSucceedTests.cs
@@ -14,6 +14,7 @@ public void Succeed()
         ok.IsFailed.Should().BeFalse();
         ok.GetError().Should().BeNull();
         ok.ThrowIfFail();
+        ok.ThrowIfFailWithStackPreserved();
         Assert.True(ok == true);
         Assert.True(ok);
         ok.AsTask().Result.IsSuccess.Should().BeTrue();
@@ -31,6 +32,7 @@ public void SucceedT()
         ok.IsFailed.Should().BeFalse();
         ok.GetError().Should().BeNull();
         ok.ThrowIfFail();
+        ok.ThrowIfFailWithStackPreserved();
         ok.Value.Message.Should().Be("msg");
 
         Assert.True(ok == true);
@@ -62,6 +64,7 @@ public void SucceedTEnum()
         ok.IsFailed.Should().BeFalse();
         ok.GetError().Should().BeNull();
         ok.ThrowIfFail();
+        ok.ThrowIfFailWithStackPreserved();
 
         Assert.True(ok == true);
         Assert.True(ok);

diff --git a/ManagedCode.Communication.Tests/Results/ResultTests.cs b/ManagedCode.Communication.Tests/Results/ResultTests.cs
@@ -142,13 +142,27 @@ public void ThrowIfFail_ShouldThrowException_WhenErrorsExist()
             Assert.Throws<Exception>(() => result.ThrowIfFail());
         }
 
+        [Fact]
+        public void ThrowIfFailWithStackPreserved_ShouldThrowException_WhenErrorsExist()
+        {
+            var result = Result<int>.Fail("TestError");
+            Assert.Throws<Exception>(() => result.ThrowIfFailWithStackPreserved());
+        }
+
         [Fact]
         public void ThrowIfFail_ShouldNotThrowException_WhenNoErrorsExist()
         {
             var result = Result<int>.Succeed(5);
             result.Invoking(r => r.ThrowIfFail()).Should().NotThrow();
         }
 
+        [Fact]
+        public void ThrowIfFailWithStackPreserved_ShouldNotThrowException_WhenNoErrorsExist()
+        {
+            var result = Result<int>.Succeed(5);
+            result.Invoking(r => r.ThrowIfFailWithStackPreserved()).Should().NotThrow();
+        }
+
         [Fact]
         public void IsErrorCode_ShouldReturnTrue_WhenErrorCodeMatches()
         {

diff --git a/ManagedCode.Communication/CollectionResultT/CollectionResult.cs b/ManagedCode.Communication/CollectionResultT/CollectionResult.cs
@@ -72,7 +72,7 @@ public void ThrowIfFailWithStackPreserved()
             return;
         }
 
-        var exceptions = Errors.Select(s => s.ExceptionInfo() ?? ExceptionDispatchInfo.Capture(new Exception(string.Join(';', s.ErrorCode, s.Message))));
+        var exceptions = Errors.Select(s => s.ExceptionInfo() ?? ExceptionDispatchInfo.Capture(new Exception(StringExtension.JoinFilter(';', s.ErrorCode, s.Message))));
 
         if (Errors.Length == 1)
         {

diff --git a/ManagedCode.Communication/Result/Result.cs b/ManagedCode.Communication/Result/Result.cs
@@ -98,7 +98,7 @@ public void ThrowIfFailWithStackPreserved()
             return;
         }
 
-        var exceptions = Errors.Select(s => s.ExceptionInfo() ?? ExceptionDispatchInfo.Capture(new Exception(string.Join(';', s.ErrorCode, s.Message))));
+        var exceptions = Errors.Select(s => s.ExceptionInfo() ?? ExceptionDispatchInfo.Capture(new Exception(StringExtension.JoinFilter(';', s.ErrorCode, s.Message))));
 
         if (Errors.Length == 1)
         {

diff --git a/ManagedCode.Communication/ResultT/Result.cs b/ManagedCode.Communication/ResultT/Result.cs
@@ -86,7 +86,7 @@ public void ThrowIfFailWithStackPreserved()
             return;
         }
 
-        var exceptions = Errors.Select(s => s.ExceptionInfo() ?? ExceptionDispatchInfo.Capture(new Exception(string.Join(';', s.ErrorCode, s.Message))));
+        var exceptions = Errors.Select(s => s.ExceptionInfo() ?? ExceptionDispatchInfo.Capture(new Exception(StringExtension.JoinFilter(';', s.ErrorCode, s.Message))));
 
         if (Errors.Length == 1)
         {
-Original file line number
+Diff line change
@@ Expand Up / @@ -72,7 +72,7 @@ public void ThrowIfFailWithStackPreserved() @@
                 return;
             }
-            var exceptions = Errors.Select(s => s.ExceptionInfo() ?? ExceptionDispatchInfo.Capture(new Exception(string.Join(';', s.ErrorCode, s.Message))));
+            var exceptions = Errors.Select(s => s.ExceptionInfo() ?? ExceptionDispatchInfo.Capture(new Exception(StringExtension.JoinFilter(';', s.ErrorCode, s.Message))));
             if (Errors.Length == 1)
             {
@@ Expand Down @@