Merge pull request #1089 from d35ha/linter-check-package-name

Check the package name against its folder and nuspec file

scripts/test/lint.py

@@ -253,12 +253,26 @@ def check(self, path):
         return True
 
 
+class PackageIdNotMatchingFolderOrNuspecName(Lint):
+    name = "package ID doesn't match package folder name or nuspec file name"
+    recommendation = "make sure the package ID is the same as the package folder name and the nuspec file name"
+
+    def check(self, path):
+        dom = minidom.parse(str(path))
+        pkg_id = dom.getElementsByTagName("id")[0].firstChild.data
+
+        nuspec = path.parts[-1]
+        folder = path.parts[-2]
+
+        return not (pkg_id == folder == nuspec[:-len(".nuspec")])
+
 NUSPEC_LINTS = (
     IncludesRequiredFieldsOnly(),
     VersionFormatIncorrect(),
     DoesNotListDependencyCommonVm(),
     DependencyContainsUppercaseChar(),
     VersionNotUpdated(),
+    PackageIdNotMatchingFolderOrNuspecName(),
 )