Skip to content

Commit

Permalink
Update comments on update_package.py
Browse files Browse the repository at this point in the history
add comments that help understand the issue that the latest sclauncher doesn't get updated. The version from the regex (current version) didn't include `v` however the function get_latest_version did include the `v`. The URL replaced the version without `v` (current version) with the latest version found that included the `v`, which resulted in the wrong URL `https://github.com/jstrosch/sclauncher/releases/download/vv0.0.6/sclauncher.exe`
  • Loading branch information
sara-rn authored Nov 11, 2024
1 parent cb75595 commit e7c24ef
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions scripts/utils/update_package.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def update_github_url(package):

latest_version = None
for url, org, project, version in matches:
# version excludes `v` from the capturing group in the regex therefore latest_version_match mustn't include `v` if the version starts with `v`
latest_version_match = get_latest_version(org, project, version)
# No newer version available
if (not latest_version_match) or (latest_version_match == version):
Expand Down

0 comments on commit e7c24ef

Please sign in to comment.