Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Test Sample for the Drakvuf Feature Extractor #240

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

yelhamer
Copy link
Contributor

This PR adds a limited sample report for the drakvuf sandbox unit tests. These tests can be found in PR (mandiant/capa#2143)

@williballenthin
Copy link
Collaborator

would you PM me a complete file so I can play around with the performance aspect, too?

@yelhamer
Copy link
Contributor Author

would you PM me a complete file so I can play around with the performance aspect, too?

Apologies for the late reply. I have sent the sample report your way :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this elf file here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a test file that got added to master after I had opened this PR. When I merged master into this PR branch the commits in question got duplicated for some reason (perhaps wrong merge strategy?).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, can you rebase to master?

@yelhamer yelhamer force-pushed the drakvuf-test-sample branch 2 times, most recently from c746b0c to 63608f3 Compare July 1, 2024 22:52
@yelhamer yelhamer requested a review from mr-tz July 1, 2024 23:04
@mr-tz mr-tz merged commit 5c3b7a8 into mandiant:master Jul 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants