Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: add file scope rules and display decimal repr for hex values #2300

Merged
merged 5 commits into from
Aug 17, 2024
Merged

web: add file scope rules and display decimal repr for hex values #2300

merged 5 commits into from
Aug 17, 2024

Conversation

fariss
Copy link
Collaborator

@fariss fariss commented Aug 16, 2024 •
edited
Loading

This PR resolves the items:

  • allow users to hover over a hex feature value to view its decimal representation
  • show capas by function: include file level matches in section as a table row

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@fariss fariss requested a review from mr-tz August 16, 2024 16:29
mr-tz
mr-tz reviewed Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't think we need octal display.

web/explorer/src/components/columns/RuleColumn.vue Outdated Show resolved Hide resolved
@mr-tz mr-tz merged commit c409b2b into mandiant:master Aug 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fariss @mr-tz