Skip to content

Commit

Permalink
feat(build): Verify CHANGELOG is updated (#1738)
Browse files Browse the repository at this point in the history
  • Loading branch information
lnist authored Jan 16, 2024
1 parent 2089b4b commit a467a07
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 23 deletions.
28 changes: 5 additions & 23 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,17 @@ env:
NODE_ENV: test

jobs:
mangrove-js:
check:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4

# == verify changelog has been updated ==
- name: Check changelog updated
uses: mangrovedao/.github/.github/actions/changelog-updated@master

- name: Yarn setup (caching yarn dependencies)
uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -81,25 +85,3 @@ jobs:
path-to-lcov: ./coverage/lcov.info
base-path: .
flag-name: js

# ==== final "check" job, using alls-green to have one single job to check for green workflow ====
# see https://github.com/re-actors/alls-green

check:
# NB: We're experimenting with using `!cancelled()` instead of `always()` in an attempt to avoid
# cancelled workflow runs blocking dependabot PR's from merging.
# Workflow runs are often cancelled automatically when a newer run is triggered.
# The problem appears to be that the `check` job runs and fails if the workflow is cancelled.
# if: always()
if: ${{ !cancelled() }}

needs:
- mangrove-js

runs-on: ubuntu-latest

steps:
- name: Decide whether the needed jobs succeeded or failed
uses: re-actors/alls-green@release/v1
with:
jobs: ${{ toJSON(needs) }}
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Next version

- Upgrade to @mangrovedao/mangrove-deployments v2.0.0
- feat: Updated CI to check `CHANGELOG.md` is updated with each PR
- fix: Able to handle backticks in changelog when releasing.

# 2.0.3

Expand Down

0 comments on commit a467a07

Please sign in to comment.