Move the ISIS SANS Interface Out of the Framework. #38047
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cailafinn
added
SANS
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @cailafinn, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
There's not really any point in having SANS.sans everywhere. RE mantidproject#37952
The models test directory has been renamed to model_tests. This resulted in PyCharm being a little overzelous with what should be updated after this name change. RE mantidproject#37952
cailafinn
force-pushed
the
37952_move_sans_gui
branch
from
f9d1263
to
38a09aa
Compare
cailafinn
removed
the
Has Conflicts
cailafinn
force-pushed
the
37952_move_sans_gui
branch
3 times, most recently
from
121a834
to
00e89ab
Compare
cailafinn
force-pushed
the
37952_move_sans_gui
branch
from
00e89ab
to
d932fe1
Compare
This is to try and get around a git renaming with uppercase to lowercase. RE mantidproject#37952
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @cailafinn, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
cailafinn
force-pushed
the
37952_move_sans_gui
branch
from
ac57930
to
7550476
Compare
cailafinn
removed
the
Has Conflicts
github-actions
bot
added
Has Conflicts
|
👋 Hi, @cailafinn, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
1 similar comment
|
👋 Hi, @cailafinn, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
Moves the main content of the ISIS SANS GUI out of the framework and into the
mantidqtinterfacespackage. This removes a lot of modules that cannot be run being available in themantidpackage where Qt is not available.Fixes #37952
Further detail of work
The move required some changes to the packages, as there was code in the
gui_logicthat was relied upon by other elements in thesansreduction package. This should now be fixed so the imports only occur one-way.To test:
loqdemoin the training course data.Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.