Pull nexus library into mantid #38455
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs mantidproject#38332 The dependencies of https://github.com/conda-forge/nexus-feedstock/blob/main/recipe/meta.yaml * hdf4 - added * hdf5 - already present * libjpeg-turbo - required by hdf4 * zlib - added * libxml2 - required by libxslt * ncurses - required by readline * readline - required by python
This creates a shared object with a bunch of compiler warnings and doesn't bother with getting tests in.
martyngigg
reviewed
Nov 27, 2024
| @@ -208,6 +208,9 @@ rel/ | |||
| mambaforge/ | |||
| miniconda3/ | |||
|
|
|||
| # in source build of conda pacakges | |||
| conda/recipes/ | |||
There was a problem hiding this comment.
Won't this ignore all changes to the sources in conda/recipes too?
There was a problem hiding this comment.
Things in .gitignore are default ignored. You can still add them explicitly.
peterfpeterson
force-pushed
the
ewm8446_nexus_into_mantid
branch
from
e402cbc
to
5bee649
Compare
peterfpeterson
force-pushed
the
ewm8446_nexus_into_mantid
branch
from
fcbd6e7
to
6bae5f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
Refs #38332.
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.