[@mantine/core] FloatingIndicator: fix translate calculations #7267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
The
borderTopWidth
&borderLeftWidth
fromparent
&target
should added to translate calculation becausegetBoundingClientRect
included that on calculation.Before
After
It's a little bit difficult to see the difference unless you use wider border width.
Notes
toInt
helper fromScrollArea
utils to convert computed style to int. That helper should be on more generic folder/file other thanScrollArea
. I'm not sure where to put it. This refactor must be in different commit.