[@mantine/core] Tooltip: add middlewares prop #7281
+94
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also room for a discussion if the inline prop should be deprecated in a new major version in favor of the middlewares prop. |
jvllmr
force-pushed
the
tooltip-middlewares
branch
from
1a85ba7 to
cdfbde3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the middlewares prop for Tooltip which lets you control the Floating UI middlewares used with the Tooltip. The implementation is derived from the Popover component. One could unite these implementations, but then there would be coupling between the Tooltip and the Popover component which wouldn't be helpful for future adjustments.
I added only one simple test demonstration in the storybook to observe my changes. Let me know if you require more tests/demos.
closes #7268