fix: replace AssertJ's deprecated asList() DSL method in ContainerEnv…

…JavaOptionsMergeVisitorTest (3379)
manusa · Sep 11, 2024 · 158b354 · 158b354
1 parent e5817e5
commit 158b354
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/...test/java/org/eclipse/jkube/enricher/generic/ContainerEnvJavaOptionsMergeVisitorTest.java b/...test/java/org/eclipse/jkube/enricher/generic/ContainerEnvJavaOptionsMergeVisitorTest.java
@@ -15,6 +15,9 @@
 
 import java.util.Collections;
 
+
+import io.fabric8.kubernetes.api.model.apps.Deployment;
+import org.assertj.core.api.InstanceOfAssertFactories;
 import org.eclipse.jkube.kit.config.image.ImageConfiguration;
 
 import io.fabric8.kubernetes.api.model.Container;
@@ -72,7 +75,7 @@ void imageConfigurationAndContainersWithMatchingImageNameAndNoEnvShouldDoNothing
     kubernetesListBuilder.accept(new ContainerEnvJavaOptionsMergeEnricher
         .ContainerEnvJavaOptionsMergeVisitor(Collections.singletonList(imageConfiguration)));
     // Then
-    assertThat(kubernetesListBuilder.build().getItems()).asList()
+    assertThat(kubernetesListBuilder.build().getItems()).asInstanceOf(InstanceOfAssertFactories.list(Deployment.class))
         .hasSize(1)
         .flatExtracting("spec.template.spec.containers")
         .flatExtracting("env").isEmpty();
@@ -91,7 +94,7 @@ void imageConfigurationWithJavaOptionsEnvAndContainersWithMatchingImageNameShoul
     kubernetesListBuilder.accept(new ContainerEnvJavaOptionsMergeEnricher
         .ContainerEnvJavaOptionsMergeVisitor(Collections.singletonList(imageConfiguration)));
     // Then
-    assertThat(kubernetesListBuilder.build().getItems()).asList()
+    assertThat(kubernetesListBuilder.build().getItems()).asInstanceOf(InstanceOfAssertFactories.list(Deployment.class))
         .hasSize(1)
         .flatExtracting("spec.template.spec.containers")
         .flatExtracting("env").isEmpty();
@@ -114,7 +117,7 @@ void imageConfigurationWithJavaOptionsEnvAndContainersWithMatchingImageNameAndEn
     kubernetesListBuilder.accept(new ContainerEnvJavaOptionsMergeEnricher
         .ContainerEnvJavaOptionsMergeVisitor(Collections.singletonList(imageConfiguration)));
     // Then
-    assertThat(containerList(kubernetesListBuilder)).asList()
+    assertThat(containerList(kubernetesListBuilder)).asInstanceOf(InstanceOfAssertFactories.list(Container.class))
         .hasSize(2)
         .filteredOn("image", "the-image:latest")
         .hasSize(1)
@@ -123,7 +126,7 @@ void imageConfigurationWithJavaOptionsEnvAndContainersWithMatchingImageNameAndEn
             new EnvVar("JAVA_OPTIONS", "-DsomeOption -DotherOption", null),
             new EnvVar("OTHER", "OTHER_VALUE", null)
         );
-    assertThat(containerList(kubernetesListBuilder)).asList()
+    assertThat(containerList(kubernetesListBuilder)).asInstanceOf(InstanceOfAssertFactories.list(Container.class))
         .filteredOn("image", "other-image:latest")
         .hasSize(1)
         .flatExtracting("env")