Skip to content

Commit

Permalink
test (jkube-kit/remote-dev) : Disable `RemoteDevelopmentServiceTest.s…
Browse files Browse the repository at this point in the history
…tartFailsIfLocalPortInUse` on JDK 8

Signed-off-by: Rohan Kumar <[email protected]>
  • Loading branch information
rohanKanojia authored and manusa committed Jan 25, 2024
1 parent be0ce2e commit edeecda
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledOnJre;
import org.junit.jupiter.api.condition.JRE;

import java.net.ServerSocket;

Expand Down Expand Up @@ -111,6 +113,7 @@ void startInitsIfLocalPortAvailable() {

@Test
@DisplayName("start fails if LocalPort for remote service is in use")
@DisabledOnJre(value = JRE.JAVA_8, disabledReason = "ServerSocket isn't throwing Bind exception for a port already in use on Eclipse CI with JDK8, see https://github.com/eclipse/jkube/issues/2576")
void startFailsIfLocalPortInUse() {
final int localPort = IoUtil.getFreeRandomPort();
RemoteService remoteService = RemoteService.builder()
Expand Down

0 comments on commit edeecda

Please sign in to comment.