Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom hooks, metadata as optional params for transferRemote() #128

Merged
merged 2 commits into from
May 6, 2024

Conversation

udit-gulati
Copy link
Contributor

@udit-gulati udit-gulati commented May 2, 2024

Fixes: hyperlane-xyz/hyperlane-monorepo#3626 task 1

  1. This change allows for user txn to have it's own custom hook and metadata.
  2. Before, whatever is the deafult hook was always going to be envoked on each warp transferRemote() call.
  3. This'll allow users to use any cutom hook, such as custom IGP for paying gas in a different denom or to a different relayer than the warp route's default one.

Copy link
Collaborator

@byeongsu-hong byeongsu-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple but effective. Thanks!

@udit-gulati
Copy link
Contributor Author

@byeongsu-hong let me know if any further changes are required or if the PR is ready to be merged.

@byeongsu-hong byeongsu-hong merged commit 3c9fd3b into many-things:main May 6, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic: Cross-chain transfer and swap middlewares
2 participants