fix: correct multisig ism signature verification logic #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix!(isms): prevent reuse of validator signature * chore: remove redundant comments * fix(isms): clear way to verify message * use hashset
* Injective updates * Additional multisig ISM actions
byeongsu-hong
changed the title
byeongsu-hong
changed the title
byeongsu-hong
changed the title
🤖 Pull request artifacts
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 67.18% 67.46% +0.27%
==========================================
Files 83 83
Lines 5278 5323 +45
Branches 5278 5323 +45
==========================================
+ Hits 3546 3591 +45
Misses 1363 1363
Partials 369 369 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Multisig ISM's logic doesn't verifies that the duplication of validators' signature. It could be vulnerable if the malicious entity hacks the one of validator's key. This PR fixes that problem.