Merge pull request #2666 from manyfold3d/fix-presupported-glitch

Fix changing presupported state causing database inconsistency

app/models/model_file.rb

@@ -18,6 +18,8 @@ class ModelFile < ApplicationRecord
   validate :presupported_version_is_presupported
   validate :presupported_files_cannot_have_presupported_version
 
+  after_update :clear_presupported_relation, if: :presupported_previously_changed?
+
   default_scope { order(:filename) }
   scope :unsupported, -> { where(presupported: false) }
   scope :presupported, -> { where(presupported: true) }
@@ -180,4 +182,8 @@ def loader
       Mittsu::OBJLoader
     end
   end
+
+  def clear_presupported_relation
+    unsupported_version&.update presupported_version: nil
+  end
 end

spec/models/model_file_spec.rb

@@ -137,5 +137,10 @@
       expect(presupported).not_to be_valid
       expect(presupported.errors[:presupported_version].first).to eq "cannot be set on a presupported file"
     end
+
+    it "clears presupported version if presupported file is set to unsupported" do
+      presupported.update!(presupported: false)
+      expect(unsupported.reload.presupported_version).to be_nil
+    end
   end
 end