Expose Placemark.properties #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
force-pushed
the
fred/public-properties
branch
from
7eaa9d4
to
cfc2e3a
Compare
Also refactored GeocodedPlacemark out of Placemark to improve readability.
frederoni
force-pushed
the
fred/public-properties
branch
from
cfc2e3a
to
af19999
Compare
1ec5
reviewed
Sep 20, 2018
| @@ -152,7 +152,7 @@ open class Placemark: NSObject, Codable { | |||
| /** | |||
| A subset of the `properties` object on a GeoJSON feature suited for Geocoding results. | |||
| */ | |||
| fileprivate var properties: Properties? | |||
| public var properties: Properties? | |||
There was a problem hiding this comment.
along with exposing
Placemark.properties, which I don't think should be exposed after a second thought because we have aliases to most of these properties. 🤔
Yeah, that was my original intention with this architecture. The Geocoding API has always been quite strictly oriented around GeoJSON, but I’ve always felt that clients of the library need a stronger, less general-purpose type system. Which properties don’t have dedicated properties?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
I've split up Placemark and GeocodedPlacemark into separate files to improve readability.
The actual changes are:
along with exposing
Placemark.properties, which I don't think should be exposed after a second thought because we have aliases to most of these properties. 🤔cc @1ec5 @riastrad