MapboxNavigationNative v28.1 #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
build
1ec5
force-pushed
the
1ec5-navigation-native-v28
branch
from
3a923e1
to
13d9414
Compare
1ec5
commented
Dec 18, 2020
| @@ -1,5 +1,6 @@ | |||
| import Foundation | |||
| import CoreLocation | |||
| import MapboxCommon | |||
There was a problem hiding this comment.
It doesn’t quite build yet due to a missing type declaration in MapboxNavigationNative.
This import fixed the build. Apparently MapboxCommon defines the MBXExpected class that MapboxNavigationNative now uses (but only forward-declares). Thanks for the suggestion, @SiarheiFedartsou!
MaximAlien
approved these changes
Dec 18, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to upgrade to MapboxNavigationNative v28.1.
It doesn’t quite build yet due to a missing type declaration in MapboxNavigationNative.Working towards #2672 and #2629.
/cc @SiarheiFedartsou @MaximAlien