Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql.yml #119

Merged
merged 14 commits into from
Jan 23, 2024
Merged

Create codeql.yml #119

merged 14 commits into from
Jan 23, 2024

Conversation

ThibaudLopez
Copy link
Contributor

Setup CodeQL using the YAML generated automatically by the CodeQL Advanced Configuration wizard to add Swift (previously just JavaScript, Python and Ruby).

see mapbox/mapbox-navigation-ios#4470 for example of CodeQL setup for Swift

setup CodeQL for Swift
@S2Ler
Copy link

S2Ler commented Jun 13, 2023

@ThibaudLopez CodeQL analysis fails.

@ThibaudLopez
Copy link
Contributor Author

yes, probably need similar to mapbox/mapbox-navigation-ios#4470

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@aokj4ck aokj4ck requested review from mapbox-danny and removed request for sarochych January 23, 2024 17:56
@aokj4ck
Copy link
Contributor

aokj4ck commented Jan 23, 2024

@SevaZhukov @ThibaudLopez the CodeQL integration should be ready for validation now.

.github/workflows/codeql.yml Outdated Show resolved Hide resolved
Copy link

@mapbox-danny mapbox-danny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThibaudLopez ThibaudLopez merged commit 6772385 into main Jan 23, 2024
4 checks passed
@ThibaudLopez ThibaudLopez deleted the ThibaudLopez-patch-1 branch January 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants