fix: Update PERMIT_TYPEHASH to be in accordance with ERC-2612 (SC-5…

…345) (#37) * fix: update typehash to be in accordance with erc-2612 * chore: update submodules
maple-labs · Mar 23, 2022 · d6256a6 · d6256a6
1 parent 082ff0f
commit d6256a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/contracts/ERC20.sol b/contracts/ERC20.sol
@@ -37,8 +37,8 @@ contract ERC20 is IERC20 {
     /*** ERC-2612 ***/
     /****************/
 
-    // PERMIT_TYPEHASH = keccak256("Permit(address owner,address spender,uint256 amount,uint256 nonce,uint256 deadline)");
-    bytes32 public constant override PERMIT_TYPEHASH = bytes32(0xfc77c2b9d30fe91687fd39abb7d16fcdfe1472d065740051ab8b13e4bf4a617f);
+    // PERMIT_TYPEHASH = keccak256("Permit(address owner,address spender,uint256 value,uint256 nonce,uint256 deadline)");
+    bytes32 public constant override PERMIT_TYPEHASH = 0x6e71edae12b1b97f4d1f60370fef10105fa2faae0126114a169c64845d6126c9;
 
     mapping(address => uint256) public override nonces;
 

diff --git a/contracts/test/ERC20.t.sol b/contracts/test/ERC20.t.sol
@@ -205,8 +205,8 @@ contract ERC20PermitTest is TestUtils {
         _user  = new ERC20User();
     }
 
-    function test_typehash() public {
-        assertEq(_token.PERMIT_TYPEHASH(), keccak256("Permit(address owner,address spender,uint256 amount,uint256 nonce,uint256 deadline)"));
+    function test_typehash() external {
+        assertEq(_token.PERMIT_TYPEHASH(), keccak256("Permit(address owner,address spender,uint256 value,uint256 nonce,uint256 deadline)"));
     }
 
     // NOTE: Virtual so inheriting tests can override with different DOMAIN_SEPARATORs because of different addresses