Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra "the" #922

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove extra "the" #922

wants to merge 2 commits into from

Conversation

ibesora
Copy link
Collaborator

@ibesora ibesora commented Nov 27, 2024

Noticed there were a couple of extra "the" in the documentation (i.e. in https://maplibre.org/maplibre-style-spec/sky/#sky-horizon-blend)
Screenshot 2024-11-27 at 12 10 03

This PR removes them

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (f5afe41) to head (a52d2fa).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         107      107           
  Lines        4739     4739           
  Branches     1346     1346           
=======================================
  Hits         4397     4397           
  Misses        342      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -4,6 +4,7 @@
- _...Add new stuff here..._

### 🐞 Bug fixes
- Remove extra "the"s in the documentation [#922](https://github.com/maplibre/maplibre-style-spec/pull/922)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it is interesting enough for a changelog entry, I would consider removing...

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants