Skip to content

Commit

Permalink
Bug 1574126 [wpt PR 18454] - [Azure Pipelines] drop old workaround fo…
Browse files Browse the repository at this point in the history
…r `safaridriver --version`, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] drop old workaround for `safaridriver --version` (#18454)

The `--version` argument is supported starting in Safari 12.1:
web-platform-tests/results-collection#617
--

wpt-commits: a2d1acf3d4e8fe76eba70ee9b5f69dba2189819f
wpt-pr: 18454

UltraBlame original commit: 5bdb6f1e8f37dfdc0ca96fdb8ae79ea0a36f2483
  • Loading branch information
marco-c committed Oct 4, 2019
1 parent 08c9af3 commit eb58fc0
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions testing/web-platform/tests/.azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -334,10 +334,7 @@ jobs:
channel: stable
- template: tools/ci/azure/update_hosts.yml
- template: tools/ci/azure/update_manifest.yml
- script: |
# TODO: drop this when `safaridriver --version` is supported.
SAFARI_VERSION="$(/usr/libexec/PlistBuddy -c 'Print :CFBundleShortVersionString' /Applications/Safari.app/Contents/Info.plist) ($(/usr/libexec/PlistBuddy -c 'Print :CFBundleVersion' /Applications/Safari.app/Contents/Info.plist))"
no_proxy='*' ./wpt run --no-manifest-update --no-restart-on-unexpected --no-fail-on-unexpected --this-chunk=$(System.JobPositionInPhase) --total-chunks=$(System.TotalJobsInPhase) --chunk-type hash --log-wptreport $(Build.ArtifactStagingDirectory)/wpt_report_$(System.JobPositionInPhase).json --log-wptscreenshot $(Build.ArtifactStagingDirectory)/wpt_screenshot_$(System.JobPositionInPhase).txt --log-tbpl - --log-tbpl-level info --browser-version "$SAFARI_VERSION" safari
- script: no_proxy='*' ./wpt run --no-manifest-update --no-restart-on-unexpected --no-fail-on-unexpected --this-chunk=$(System.JobPositionInPhase) --total-chunks=$(System.TotalJobsInPhase) --chunk-type hash --log-wptreport $(Build.ArtifactStagingDirectory)/wpt_report_$(System.JobPositionInPhase).json --log-wptscreenshot $(Build.ArtifactStagingDirectory)/wpt_screenshot_$(System.JobPositionInPhase).txt --log-tbpl - --log-tbpl-level info safari
displayName: 'Run tests'
- task: PublishBuildArtifacts@1
displayName: 'Publish results'
Expand Down

0 comments on commit eb58fc0

Please sign in to comment.