Use 1xx as expected response when requesting a data connection #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an issue where when I call
StoreFile
, the server responds with125 Data connection already open; Transfer starting.
, which this library treats as an unexpected code and incorrectly aborts the transfer.I don't have control over this server, and I'm not sure why it is responding this way (I am only opening one connection in a simple script to store one file, and I always close the connection afterwards). But regardless, 125 is not actually an error code, and if we treat it as a success code the file still gets uploaded just fine.
So this commit changes the expected response to 1xx, which should match any positive response, as described here.