Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Timestamps and minor refactor #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tuxino
Copy link

@Tuxino Tuxino commented Dec 18, 2024

Hi Marco

Another pull request related to the following issue #7

Timestamps added to all collectors
Some refactoring of tests / exposers
readme updated

Signed-off-by: David Aspden [email protected]

Timestamps added to all collectors
Some refactoring of tests / exposers
readme updated
@marcobreveglieri
Copy link
Owner

Hi Tuxino,
I peeked at the changes proposed in the pull request.

There are many interventions on different points, even structural ones, like a new private TLock object in descendant classes of collectors, just to name one.

I wanted to ask you if these improvements are related to effective problems that emerged from tests and usages that you have made in production: since these are fairly internal changes to classes that are fundamental for the library, and since I have not received any feedback on troubles with them till now, I want to be sure not to introduce regression errors within the library.

Can you give me some brief details about this?

Thanks as always for your collaboration! 🤗

Regards,
Marco.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants